Always add KeyGenerator to olp-sdk-core#1637
Merged
andrey-kashcheev merged 1 commit intomasterfrom Oct 10, 2025
Merged
Conversation
KeyGenerator is being used outside the cache and needs to be included regardless of `OLP_SDK_ENABLE_DEFAULT_CACHE` value Relates-To: NLAM-141 Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
andrey-kashcheev
force-pushed
the
nlam-141-key-generator
branch
from
1b9474d to
e83b131
Compare
rustam-gamidov-here
approved these changes
Oct 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1637 +/- ##
==========================================
- Coverage 80.32% 80.27% -0.05%
==========================================
Files 349 349
Lines 13953 13954 +1
Branches 1493 1493
==========================================
- Hits 11207 11201 -6
- Misses 2147 2151 +4
- Partials 599 602 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykolamalik
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyGenerator is being used outside the cache and needs to be included regardless of
OLP_SDK_ENABLE_DEFAULT_CACHEvalue