Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 80.30% 80.29% -0.02%
==========================================
Files 349 349
Lines 13937 13940 +3
Branches 1491 1492 +1
==========================================
Hits 11192 11192
- Misses 2146 2150 +4
+ Partials 599 598 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeRequest.h
Show resolved
Hide resolved
andrey-kashcheev
previously approved these changes
Aug 7, 2025
olp-cpp-sdk-authentication/include/olp/authentication/TokenResult.h
Outdated
Show resolved
Hide resolved
6379075 to
302a333
Compare
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a second part of the task: olp-cpp-sdk-authentication. Relates-To: NLAM-23 Signed-off-by: sopov <ext-alexander.sopov@here.com>
302a333 to
fef9e8d
Compare
andrey-kashcheev
approved these changes
Aug 8, 2025
rustam-gamidov-here
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a second part of the task: olp-cpp-sdk-authentication.
Relates-To: NLAM-23