Avoid boost::optional::has_value()#1622
Merged
rustam-gamidov-here merged 1 commit intomasterfrom Jul 11, 2025
Merged
Conversation
There are checks on old boost versions without this method Relates-To: MINOR Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/remove-has-value
branch
from
df6ead5 to
6c459de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
+ Coverage 80.30% 80.33% +0.02%
==========================================
Files 348 348
Lines 13932 13934 +2
Branches 1489 1490 +1
==========================================
+ Hits 11188 11193 +5
+ Misses 2146 2144 -2
+ Partials 598 597 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rustam-gamidov-here
requested review from
andrey-kashcheev,
diachenko-mischa and
mykolamalik
diachenko-mischa
approved these changes
Jul 11, 2025
mykolamalik
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are checks on old boost versions without this method
Relates-To: MINOR