Custom body to be sent to URL from Credentials#1620
Merged
diachenko-mischa merged 4 commits intomasterfrom Jul 10, 2025
Merged
Conversation
Here credentials file specifies the endpoint that should be used to retrieve authentication token. HNAV backend, which implements mTLS authentication also conforms to a bit different body and response schema. Add a possibility to add a custom body for the authentication request and parsing of token from HNAV mTLS server. Relates-To: HERESDK-7942 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
dc688c6 to
3be1714
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
+ Coverage 80.23% 80.29% +0.06%
==========================================
Files 348 348
Lines 13882 13933 +51
Branches 1483 1490 +7
==========================================
+ Hits 11138 11187 +49
- Misses 2146 2147 +1
- Partials 598 599 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Message to make CI happy Relates-To: HERESDK-7942 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
3be1714 to
80a008b
Compare
Some files where not covered with dedicated unit tests Relates-To: HERESDK-7942 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
62df4a3 to
24384e3
Compare
Message to make CI happy Relates-To: HERESDK-7942 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
24384e3 to
42e4464
Compare
andrey-kashcheev
approved these changes
Jul 10, 2025
Collaborator
rustam-gamidov-here
left a comment
There was a problem hiding this comment.
No comments to the code but it make sense to update years in the files changed
mykolamalik
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here credentials file specifies the endpoint that
should be used to retrieve authentication token.
HNAV backend, which implements mTLS authentication also conforms to a bit different body and response schema.
Add a possibility to add a custom body for the authentication request and parsing of token from HNAV mTLS server.
Relates-To: HERESDK-7942