Skip to content

Custom body to be sent to URL from Credentials#1620

Merged
diachenko-mischa merged 4 commits intomasterfrom
mdiachenko/HERESDK-7942-CustomBodyAndUrl
Jul 10, 2025
Merged

Custom body to be sent to URL from Credentials#1620
diachenko-mischa merged 4 commits intomasterfrom
mdiachenko/HERESDK-7942-CustomBodyAndUrl

Conversation

@diachenko-mischa
Copy link
Contributor

Here credentials file specifies the endpoint that
should be used to retrieve authentication token.
HNAV backend, which implements mTLS authentication also conforms to a bit different body and response schema.

Add a possibility to add a custom body for the authentication request and parsing of token from HNAV mTLS server.

Relates-To: HERESDK-7942

Here credentials file specifies the endpoint that
should be used to retrieve authentication token.
HNAV backend, which implements mTLS authentication
also conforms to a bit different body and response
schema.

Add a possibility to add a custom body for the authentication request
and parsing of token from HNAV mTLS server.

Relates-To: HERESDK-7942
Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
@diachenko-mischa diachenko-mischa force-pushed the mdiachenko/HERESDK-7942-CustomBodyAndUrl branch 2 times, most recently from dc688c6 to 3be1714 Compare July 10, 2025 05:03
@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 92.95775% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (66cb092) to head (42e4464).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...lp-cpp-sdk-authentication/src/SignInResultImpl.cpp 90.62% 0 Missing and 3 partials ⚠️
...dk-authentication/src/AuthenticationClientImpl.cpp 96.67% 1 Missing ⚠️
olp-cpp-sdk-core/src/utils/Url.cpp 88.89% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1620      +/-   ##
==========================================
+ Coverage   80.23%   80.29%   +0.06%     
==========================================
  Files         348      348              
  Lines       13882    13933      +51     
  Branches     1483     1490       +7     
==========================================
+ Hits        11138    11187      +49     
- Misses       2146     2147       +1     
- Partials      598      599       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Message to make CI happy

Relates-To: HERESDK-7942

Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
@diachenko-mischa diachenko-mischa force-pushed the mdiachenko/HERESDK-7942-CustomBodyAndUrl branch from 3be1714 to 80a008b Compare July 10, 2025 06:06
Some files where not covered with dedicated unit tests

Relates-To: HERESDK-7942
Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
@diachenko-mischa diachenko-mischa force-pushed the mdiachenko/HERESDK-7942-CustomBodyAndUrl branch 3 times, most recently from 62df4a3 to 24384e3 Compare July 10, 2025 08:18
Message to make CI happy

Relates-To: HERESDK-7942
Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
@diachenko-mischa diachenko-mischa force-pushed the mdiachenko/HERESDK-7942-CustomBodyAndUrl branch from 24384e3 to 42e4464 Compare July 10, 2025 08:26
Copy link
Collaborator

@rustam-gamidov-here rustam-gamidov-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments to the code but it make sense to update years in the files changed

@diachenko-mischa diachenko-mischa merged commit cd53cc3 into master Jul 10, 2025
24 checks passed
@diachenko-mischa diachenko-mischa deleted the mdiachenko/HERESDK-7942-CustomBodyAndUrl branch July 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants