Skip internal keys' lookup in LRU for the DefaultCache.#1615
Merged
asopov-here merged 4 commits intomasterfrom Jun 12, 2025
Merged
Skip internal keys' lookup in LRU for the DefaultCache.#1615asopov-here merged 4 commits intomasterfrom
asopov-here merged 4 commits intomasterfrom
Conversation
asopov-here
force-pushed
the
DATASDK-71-internal-keys
branch
4 times, most recently
from
c6a9a70 to
a55e373
Compare
for the DefaultCache. Relates-To: DATASDK-71 Signed-off-by: sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
DATASDK-71-internal-keys
branch
from
a55e373 to
3d31910
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
+ Coverage 80.18% 80.27% +0.09%
==========================================
Files 348 348
Lines 13883 13882 -1
Branches 1483 1482 -1
==========================================
+ Hits 11132 11143 +11
+ Misses 2150 2142 -8
+ Partials 601 597 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrey-kashcheev
requested changes
Jun 12, 2025
for the DefaultCache. Add test. Relates-To: DATASDK-71 Signed-off-by: sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
DATASDK-71-internal-keys
branch
from
129bd93 to
10d8395
Compare
andrey-kashcheev
previously approved these changes
Jun 12, 2025
Contributor
andrey-kashcheev
left a comment
andrey-kashcheev
left a comment
There was a problem hiding this comment.
Few minor comments, feel free to skip
for the DefaultCache. Add test. Relates-To: DATASDK-71 Signed-off-by: sopov <ext-alexander.sopov@here.com>
for the DefaultCache. Add test. Relates-To: DATASDK-71 Signed-off-by: sopov <ext-alexander.sopov@here.com>
andrey-kashcheev
approved these changes
Jun 12, 2025
mykhailo-kuchma
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, for mutable cache, the key should be in the protected list or LRU to be read. Internal keys are pretty important and should have priority to be read without additional restrictions.
Relates-to: DATASDK-71