Change NetworkWinHttp implementation#1608
Conversation
Make sure we are using http2 when it's possible Relates-To: DATASDK-63 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1608 +/- ##
=======================================
Coverage 80.23% 80.23%
=======================================
Files 348 348
Lines 13881 13881
Branches 1481 1481
=======================================
Hits 11137 11137
Misses 2146 2146
Partials 598 598 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| DWORD flags = (url_components.nScheme == INTERNET_SCHEME_HTTPS) | ||
| ? WINHTTP_FLAG_SECURE | ||
| : 0; | ||
| LPWSTR http_verb = L"GET"; |
There was a problem hiding this comment.
I pulled the latest version of master. When I try to compile with Visual Stusio 2026 I get this error: Error C2440: 'initializing': cannot convert from 'const wchar_t [4]' to 'LPWSTR'
There was a problem hiding this comment.
Done - #1654
Thank you for looking into it.
pjdixit
left a comment
pjdixit
left a comment
There was a problem hiding this comment.
I pulled the latest version of master. When i compile with VS 2026 I get this error on line
error C2440: 'initializing': cannot convert from 'const wchar_t [4]' to 'LPWSTR'
4 participants
Make sure we are using http2 when it's possible
Relates-To: DATASDK-63