Fix the data race in NetworkCurl#1595
Merged
mykhailo-kuchma merged 1 commit intomasterfrom Mar 10, 2025
Merged
Conversation
Fix the RequestHandle initialization; have to be protected with a mutex Fix the condition in cancel event handling, to avoid canceling wrong requests Relates-To: DATASDK-69 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1595 +/- ##
==========================================
- Coverage 80.16% 80.16% -0.00%
==========================================
Files 347 347
Lines 13756 13755 -1
Branches 1472 1470 -2
==========================================
- Hits 11027 11026 -1
Misses 2133 2133
Partials 596 596 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrey-kashcheev
approved these changes
Mar 10, 2025
mykolamalik
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the RequestHandle initialization; it has to be protected with a mutex
Fixed the condition in cancel event handling to avoid canceling wrong requests
Relates-To: DATASDK-69