Skip to content

Fix the data race in NetworkCurl#1595

Merged
mykhailo-kuchma merged 1 commit intomasterfrom
task/DATASDK-69
Mar 10, 2025
Merged

Fix the data race in NetworkCurl#1595
mykhailo-kuchma merged 1 commit intomasterfrom
task/DATASDK-69

Conversation

@mykhailo-kuchma
Copy link
Contributor

Fixed the RequestHandle initialization; it has to be protected with a mutex
Fixed the condition in cancel event handling to avoid canceling wrong requests

Relates-To: DATASDK-69

Fix the RequestHandle initialization; have to be protected with a mutex
Fix the condition in cancel event handling, to avoid canceling wrong
requests

Relates-To: DATASDK-69

Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (884a201) to head (c76ac1a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1595      +/-   ##
==========================================
- Coverage   80.16%   80.16%   -0.00%     
==========================================
  Files         347      347              
  Lines       13756    13755       -1     
  Branches     1472     1470       -2     
==========================================
- Hits        11027    11026       -1     
  Misses       2133     2133              
  Partials      596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mykhailo-kuchma mykhailo-kuchma merged commit 4013ab3 into master Mar 10, 2025
24 checks passed
@mykhailo-kuchma mykhailo-kuchma deleted the task/DATASDK-69 branch March 10, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants