Extend network response with diagnostics#1588
Merged
mykhailo-kuchma merged 1 commit intomasterfrom Feb 10, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1588 +/- ##
==========================================
- Coverage 81.38% 81.37% -0.01%
==========================================
Files 345 345
Lines 13545 13550 +5
Branches 1465 1464 -1
==========================================
+ Hits 11023 11026 +3
- Misses 1925 1928 +3
+ Partials 597 596 -1 ☔ View full report in Codecov by Sentry. |
rustam-gamidov-here
previously approved these changes
Feb 10, 2025
mykhailo-kuchma
force-pushed
the
task/OCMAM-418-diag
branch
from
dcccaf4 to
dcf15c1
Compare
mykhailo-kuchma
force-pushed
the
task/OCMAM-418-diag
branch
from
dcf15c1 to
8e72a42
Compare
Implement request diagnostics for NetworkCurl. Add response timings for a request, it includes timings for: * queue time * dns resolution time * connect + ssl handshake time * send, wait, receive time * total time taken Relates-To: OCMAM-418 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
rustam-gamidov-here
approved these changes
Feb 10, 2025
andrey-kashcheev
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement request diagnostics for NetworkCurl.
Add response timings for a request, it includes timings for:
Relates-To: OCMAM-418