Minor refactoring in NetworkCurl#1587
Merged
mykhailo-kuchma merged 1 commit intomasterfrom Feb 7, 2025
Merged
Conversation
mykhailo-kuchma
force-pushed
the
task/OCMAM-418-ref
branch
from
75fca23 to
6ffa791
Compare
Use RAII for curl easy handles Change the RequestHandle initialization sequence Relates-To: OCMAM-418 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1587 +/- ##
==========================================
- Coverage 81.41% 81.37% -0.04%
==========================================
Files 345 345
Lines 13543 13544 +1
Branches 1463 1465 +2
==========================================
- Hits 11026 11021 -5
- Misses 1922 1927 +5
- Partials 595 596 +1 ☔ View full report in Codecov by Sentry. |
andrey-kashcheev
approved these changes
Feb 7, 2025
rustam-gamidov-here
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use RAII for curl easy handles
Change the RequestHandle initialization sequence
Relates-To: OCMAM-418