Do not propagate -Werror from leveldb#1583
Merged
mykhailo-kuchma merged 1 commit intomasterfrom Jan 22, 2025
Merged
Conversation
Setting -Werror as PUBLIC flag means that all targets that link to leveldb will stop compiling on the first warning. An intermediate library must never propagate that flag to parent projects. Relates-To: MINOR Signed-off-by: Harald Fernengel <harald.fernengel@here.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1583 +/- ##
=======================================
Coverage 81.41% 81.41%
=======================================
Files 345 345
Lines 13541 13542 +1
Branches 1462 1463 +1
=======================================
+ Hits 11024 11025 +1
Misses 1923 1923
Partials 594 594 ☔ View full report in Codecov by Sentry. |
andrey-kashcheev
approved these changes
Jan 21, 2025
mykhailo-kuchma
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting -Werror as PUBLIC flag means that all targets that link to leveldb will stop compiling on the first warning. An intermediate library must never propagate that flag to parent projects.
Relates-To: MINOR