Check write buffer on stream closed check#1578
Merged
andrey-kashcheev merged 1 commit intomasterfrom Jan 9, 2025
Merged
Conversation
mykhailo-kuchma
previously approved these changes
Jan 8, 2025
Helps to avoid "empty JSON" errors when stream is being reset Relates-To: DATASDK-57 Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
andrey-kashcheev
force-pushed
the
datasdk-57-write-buffer-check
branch
from
5626318 to
49e9ecb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
+ Coverage 81.39% 81.45% +0.06%
==========================================
Files 345 345
Lines 13539 13542 +3
Branches 1462 1462
==========================================
+ Hits 11019 11030 +11
+ Misses 1924 1919 -5
+ Partials 596 593 -3 ☔ View full report in Codecov by Sentry. |
mykhailo-kuchma
approved these changes
Jan 9, 2025
rustam-gamidov-here
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps to avoid "empty JSON" errors when stream is being reset
Relates-To: DATASDK-57