[asl][www] Refactor running of ASLRef#1799
Open
hrutvik wants to merge 2 commits into
Open
Conversation
Roman-Manevich
approved these changes
Apr 20, 2026
Collaborator
Roman-Manevich
left a comment
Roman-Manevich
left a comment
There was a problem hiding this comment.
Looks good to me!
HadrienRenaud
approved these changes
Apr 20, 2026
Collaborator
HadrienRenaud
left a comment
HadrienRenaud
left a comment
There was a problem hiding this comment.
Thanks for this @hrutvik. Just 2 minor comments.
Library for running ASLRef, and used by both `aslref.ml` and `jaslref.ml`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
Runnermodule to better delimit functionality for running ASLRef, allowingaslref.mlandjaslref.mlto each use this module without copyingaslref.mlintojaslref.ml. As suggested by @HadrienRenaud.