Draft
Conversation
Although the issue has not been resolved yet, it's not actually a problem here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
PutUint64in Dafnyslayers.(*SCION)in the preconditions of e.g.prepareMacInputinepic.goin anIsLowfunctionpkg/slayershas been merged, which also defines such a functiontime.Time.Afteras (hyper)pureagain. At the moment, this is prevented by Gobra issue 965.NewCBCEncrypters.t. it doesn't always requirebandivto be low and ensureIsLowof the returnedBlockMode, by replacing the corresponding pre- and postcondition by a postcondition with an implication (as was done forBlockMode.CryptBlocksoraes.NewCipher)CryptBlocksandNewCipher, depending on how general the contract should beBesides these TODOs, this still contains workarounds for Gobra issues 846 and 955, which should be tracked by issues #14 and #15 (resp.)
OTHER KNOWN ISSUES
outlineblock inprepareMacInputis still somewhat unstable (although verification performance has increased dramatically by introducing theoutlineblock)slices.gobraverifies successfully on its own, during the verification ofpkg/experimental/epic, Gobra will consistently complain about insufficient permissions in the contract ofCombineRange_Bytes(also seeNOTEcomment there)