Load css first#47
Merged
Merged
Conversation
- Allow plain quick reply buttons to send messages without product card data - Scope teaser session visibility to the rendered teaser version - Add a transient opening class so popover animation only runs when opening - Update generated lib and dist builds - Add tests for quick replies, teaser versioning, and popover open animation
…o explicit cable URL is provided. This keeps local and custom API environments connected to the matching websocket endpoint while preserving explicit actionCableUrl overrides.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 820735e7bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes when and whether the webchat appears (stylesheet gate) and how messages, Action Cable URL, and carousel/quick-reply flows behave in production embeds.
Overview
This PR tightens webchat mounting so widget HTML is not inserted until the Hellotext business stylesheet has loaded (or aborts with a warning if CSS fails), with tests for
Businessstylesheet promises andWebchat.rendered/mountedbehavior.Configuration gains tests that
actionCableUrlis derived fromapiRootwhen not set explicitly, keeping WebSocket endpoints aligned with custom API hosts.Webchat UX coverage expands for locale-aware message timestamps, failure reasons on failed sends (including broadcast
reason), capture-phase Escape to close the popover, open animation hooks, compose focus that does not steal focus from the emoji picker, and teaser “seen” keys scoped by teaser version.Message / carousel tests document page-aligned carousel scrolling (next/previous page helpers), gradient fade edge cases, and quick replies that work without a product card (body fallbacks and null optional FormData fields).
Reviewed by Cursor Bugbot for commit 820735e. Bugbot is set up for automated code reviews on this repo. Configure here.