Conversation
helloseyedjafari
requested changes
May 11, 2020
app/src/main/java/com/worldsnas/starplayer/model/persistent/FavoriteMusic.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/worldsnas/starplayer/model/persistent/AppDataBase.kt
Show resolved
Hide resolved
FatemehMsp
reviewed
May 16, 2020
app/src/main/java/com/worldsnas/starplayer/view/musics_list/MusicsListAdapter.kt
Outdated
Show resolved
Hide resolved
FatemehMsp
reviewed
May 16, 2020
app/src/main/java/com/worldsnas/starplayer/view/musics_list/MusicListViewModel.kt
Show resolved
Hide resolved
add a generic mapper interface
IamHaddad
commented
May 25, 2020
app/src/main/java/com/worldsnas/starplayer/model/MusicMapper.kt
Outdated
Show resolved
Hide resolved
helloseyedjafari
requested changes
May 25, 2020
Owner
helloseyedjafari
left a comment
helloseyedjafari
left a comment
There was a problem hiding this comment.
you need to rethink your repo
app/src/main/java/com/worldsnas/starplayer/model/MusicRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/worldsnas/starplayer/model/persistent/FavoriteMusicDao.kt
Show resolved
Hide resolved
app/src/main/java/com/worldsnas/starplayer/view/musics_list/MusicListViewModel.kt
Outdated
Show resolved
Hide resolved
FatemehMsp
reviewed
Jun 1, 2020
app/src/main/java/com/worldsnas/starplayer/view/musics_list/MusicsListAdapter.kt
Outdated
Show resolved
Hide resolved
helloseyedjafari
requested changes
Jun 5, 2020
Owner
helloseyedjafari
left a comment
helloseyedjafari
left a comment
There was a problem hiding this comment.
Looks awesome. just some final touches
app/src/main/java/com/worldsnas/starplayer/model/LocalMusicProviderImpl.kt
Show resolved
Hide resolved
Repository owner
locked and limited conversation to collaborators
Apr 16, 2021
Repository owner
unlocked this conversation
Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.