Skip to content

fix: Remove stale kodit image and persistence config from Helm chart#1758

Open
chocobar wants to merge 1 commit intomainfrom
fix/remove-stale-kodit-image-config
Open

fix: Remove stale kodit image and persistence config from Helm chart#1758
chocobar wants to merge 1 commit intomainfrom
fix/remove-stale-kodit-image-config

Conversation

@chocobar
Copy link
Copy Markdown
Collaborator

Summary

  • Remove dead kodit.image config from values.yaml and values-example.yaml — Kodit is now a Go library compiled into the controlplane binary, not a separate container
  • Remove dead kodit.persistence config — Kodit's data directory now lives on the controlplane's existing /filestore PVC (defaults to {filestore}/kodit)
  • Update comments to reflect Kodit's current architecture

What's kept (still used in templates)

  • kodit.enabled, kodit.auth, kodit.enrichment, kodit.vectorchord — all still referenced in deployment templates

Breaking change risk

Low. Helm silently ignores unused values keys, so existing overrides with kodit.image or kodit.persistence won't cause deployment failures.

Test plan

  • helm template renders without errors
  • Existing deployments with kodit enabled continue to work
  • Verified no template references kodit.image or kodit.persistence

🤖 Generated with Claude Code

Kodit is now compiled into the controlplane binary as a Go library,
not deployed as a separate container. Remove dead values that no
template references: kodit.image and kodit.persistence. Kodit's data
directory now lives on the controlplane's existing /filestore PVC.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@philwinder philwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

# existingSecret: "kodit-enrichment"
# existingSecretKey: "api-key"

# Persistence for kodit data
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only contentious bit. Kodit needs a place to store it's data. Ideally it's somewhat persistent so it doesn't need to re-clone repos and such.

It defaults to the filestore path: https://github.com/helixml/helix/blob/main/api/pkg/server/kodit_init.go#L49

But it is configurable in the settings.

Also, I think this will mean it will delete user's current data and re-clone.

I think this is fine, but FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants