Skip to content

POWER 4446 Fix authentication token refresh #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolaiHoel merged 2 commits into from
Jan 20, 2026
Merged

POWER 4446 Fix authentication token refresh #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e007c
Remove old headers before adding new on token refresh
NicolaiHoel Jan 20, 2026
fdac325
Add more dynamic header refresh
NicolaiHoel Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dotnet/HeimdallPower.Api.Client/HeimdallPower.Api.Client/HeimdallApiHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,16 @@ private async Task RefreshAccessToken()
await _tokenLock.WaitAsync(TimeSpan.FromSeconds(30));
try
{
// Check if another thread already refreshed while we were waiting
if (_tokenExpiresOn != default && DateTimeOffset.UtcNow.Add(TokenExpirationBuffer) <= _tokenExpiresOn)
return;
Comment thread
NicolaiHoel marked this conversation as resolved.

await accessTokenProvider.AcquireTokenAsync();
_tokenExpiresOn = accessTokenProvider.GetTokenExpiry();

foreach (var header in accessTokenProvider.GetAccessHeaders())
{
HttpClient.DefaultRequestHeaders.Remove(header.Key);
HttpClient.DefaultRequestHeaders.TryAddWithoutValidation(header.Key, header.Value);
}
foreach (var header in BuildClientHeaders())
Expand All @@ -124,6 +130,7 @@ private async Task RefreshAccessToken()
continue; // Skip adding x-region as this should be set from the token
}

HttpClient.DefaultRequestHeaders.Remove(header.Key);
HttpClient.DefaultRequestHeaders.TryAddWithoutValidation(header.Key, header.Value);
}
}
Expand Down