You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the issue here is simply that this repository is using pull_request_target instead of pull_request as the action trigger. Although maybe that is needed because of the private repo, so I guess that's why this workaround is needed here.
I think the issue here is simply that this repository is using pull_request_target instead of pull_request as the action trigger. Although maybe that is needed because of the private repo, so I guess that's why this workaround is needed here.
hm...I'm going to open this PR for review, if anyone wanna look into it. unfortunately, I can't fully test nor verify myself til then.
Bit late on this but one thing: if the repo is using pull_request_target instead of just pull_request out of security concerns with CI secrets or private files, I don't think it will be possible to have PR CI build since even if you avoid running the PR branch CI workflows, as long as you are running build scripts from the PR branch they can do whatever.
So I think either it should just get changed to pull_request maybe with some trusted user authorization or there shouldn't be a PR build at all, doing something like this doesn't solve the reason for not just using pull_request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a poor man's attempt on addressing GitHub Action doesn't respect Pull Requests and it's branches while validating. #1311
As this simple change might break GitHub Actions in the process, serious verification will be needed first. For now: this will be a Draft PR.