Don't hold a reference to a GraphicsCaptureItem when not capturing#44
Open
TheLastRar wants to merge 1 commit intohecomi:masterfrom
Open
Don't hold a reference to a GraphicsCaptureItem when not capturing#44TheLastRar wants to merge 1 commit intohecomi:masterfrom
TheLastRar wants to merge 1 commit intohecomi:masterfrom
Conversation
Owner
|
Thanks for the pull request. Please give me a few moments to review. |
Owner
|
Sorry for the delay in replying. I have tried and it worked in Windows Graphics Capture mode. However, uWC currently has three capture methods (Windows Graphics Capture / PrintWindow / BitBlt). If Auto mode is set, it tries Windows Graphics Capture first, and if it is not available (e.g. in the case where it captures child windows), then try the other available methods. If |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only create the GraphicsCaptureItem just before we need to use the capture
This will allow the Windows Graphics Capture service to suspend itself when we are not capturing
This also gives the bonus effect of no longer having issues when the service dies while we aren't capturing (which would crash uWC without #43
This did require a couple changes I would like you to review the impact of;
Removal of IsAvailable, as this relied on a persistent item_, this may affect any code that ensures capture is possible
Using GetWindowTitle() when a given item is not capturing