Enable shadow cookie support and fix sharp line in normal mapped shell materials#13
Open
thnewlands wants to merge 2 commits intohecomi:mainfrom
Open
Enable shadow cookie support and fix sharp line in normal mapped shell materials#13thnewlands wants to merge 2 commits intohecomi:mainfrom
thnewlands wants to merge 2 commits intohecomi:mainfrom
Conversation
This solves the hard line seen when using a normal map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normal mapped shell materials currently make a hard line that follows the camera. Using the tangent's orientation information from the mesh we can replace view direction as the orientation of the normal map.
Additionally -- enable shadow cookie support with a multi_compile.