[FE-9524] migrate Line-Combo, Invalid time value#102
Open
mikehinchey wants to merge 1 commit intomasterfrom
Open
[FE-9524] migrate Line-Combo, Invalid time value#102mikehinchey wants to merge 1 commit intomasterfrom
mikehinchey wants to merge 1 commit intomasterfrom
Conversation
int3h
approved these changes
Jun 15, 2022
Contributor
int3h
left a comment
int3h
left a comment
There was a problem hiding this comment.
This old PR keeps showing up in my GitHub, so leaving a review to close it out. Sorry for the old thread bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem with the errors I get when migrating a Line to Combo, when filters are active which produce zero rows. The fix is to simply return the string if there is an error parsing as a date.
I do not know yet why the dashboard is interpreting these text values as timestamps.