-
Notifications
You must be signed in to change notification settings - Fork 0
Fix mesh remeshing performance: implement missing involved_faces index usage #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
master
Choose a base branch
from
copilot/debug-mesh-simplification-issues
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+410
−113
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8033452
Initial plan
Copilot c1682fb
Fix mesh remeshing performance: use involved_faces index, batch split…
Copilot dd28ed6
Address code review: restore break-restart for split safety, add qual…
Copilot 8801780
Update tests2/YgorMeshesRemeshing.cc
hdclark 82a899b
Add involved_face_index_diff for surgical index updates, add bounds c…
Copilot ce44a9b
Refactor do_collapse_edge: record swap ops in Phase 2, replay in Phase 4
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment claims applying a diff “is identical to what recreate_involved_face_index() would produce”, but apply_involved_face_index_diff() does not validate preconditions (e.g., involved_faces currently matches the pre-change mesh, diff is complete, and new_vertex_count brings involved_faces to vertices.size()). Consider clarifying these preconditions in the doc comment (or add defensive checks) to avoid implying it self-heals a stale/corrupted index.