Treat wildcard as ? instead of *#298
Open
groverlynn wants to merge 1 commit intohchunhui:masterfrom
Open
Conversation
Conventionally, one wildcard in IMK matches exactly one input code. Especially, It makes no sense to match nothing and this only results in confusingly reordered candidates. Also, in most cases, users know exactly how long the input code would be and how many of them should be guessed by wildcard, using one wildcard to match multiple characters is also uncommon and, depending on sorting of dictionary, could even impede input. So, it shall be necessary to check the length of input code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conventionally, one wildcard in IMK matches exactly one input code. Especially, It makes no sense to match nothing and this only results in confusingly reordered candidates. Also, in most cases, users know exactly how long the input code would be and how many of them should be guessed by wildcard, using one wildcard to match multiple characters is also uncommon and, depending on sorting of dictionary, could even impede input. So, it shall be necessary to check the length of input code