Added bitchat bluetooth mesh service and characteristic UUIDs#1798
Open
o-murphy wants to merge 1 commit intohbldh:developfrom
Open
Added bitchat bluetooth mesh service and characteristic UUIDs#1798o-murphy wants to merge 1 commit intohbldh:developfrom
o-murphy wants to merge 1 commit intohbldh:developfrom
Conversation
Collaborator
|
I guess this is OK, but would really rather prefer moving towards some package that automatically generates these sorts of lookup tables from https://github.com/NordicSemiconductor/bluetooth-numbers-database rather than maintaining our own tables in Bleak. |
Contributor
Author
But wouldn't using such databases overburden the library (it's quite thin at the moment)? Or do you want to implement this as an optional dependency for those who really need these descriptors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Bitchat Bluetooth Mesh Service and Characteristic UUIDs, Referred to official Bitchat repo.