Skip to content

Fix Miscasting [API-2378] [HZ-5417] #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emreyigit wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Miscasting [API-2378] [HZ-5417] #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1257917
Fix mis casting.
emreyigit Apr 7, 2026
7c079d4
add tests
emreyigit Apr 20, 2026
a3977c1
fix format
emreyigit Apr 20, 2026
dc6c5be
Merge branch 'master' into fix-twos-complement
ihsandemir Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hazelcast/src/hazelcast/client/client_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ twos_complement(std::vector<int8_t>& a)
}
// add 1
int8_t carry = 1;
for (auto i = a.size() - 1; i >= 0; i--) {
for (int i = static_cast<int>(a.size()) - 1; i >= 0; i--) {
a[i] = a[i] + carry;
if (a[i] == 0) {
carry = 1;
Expand Down
18 changes: 18 additions & 0 deletions hazelcast/test/src/HazelcastTests2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,24 @@ TEST_F(DecimalTest, cascading_carry_bit_test)
{ -67, 19, -58, 119, -111, -77, 0, 0, 0 });
}

TEST_F(DecimalTest, twos_complement_single_byte_full_carry)
{
// carry propagates out of the only byte; the signed loop index must exit
// cleanly
std::vector<int8_t> v = { 0 };
pimpl::twos_complement(v);
ASSERT_EQ((std::vector<int8_t>{ 0 }), v);
}

TEST_F(DecimalTest, twos_complement_multi_byte_full_carry)
{
// carry propagates out of every byte; a size_t loop index would wrap to
Copy link
Copy Markdown
Collaborator

@ihsandemir ihsandemir Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this comment mean? you changed size_t usage to int int he loop at this PR.

Copy link
Copy Markdown
Member Author

@emreyigit emreyigit Apr 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, only way to test it is calling the function and verifying its result. I just explained the situation what was it before. Also, I couldn't find any test on twos_complement, so I added single and multiple vector size test which verifies both loop and the function.

Copy link
Copy Markdown
Collaborator

@ihsandemir ihsandemir Apr 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there were existing tests for the complement (see DecimalTest::.... test cases above your added test. e.g. TEST_F(DecimalTest, carry_bit_test)) but not for this exact scenario. you need a specific value to actually see the index goes all the way to 0. Your added tests are OK but they do not catch the infinite loop problem, right? Does you test catch the failure without the fix?

Copy link
Copy Markdown
Member Author

@emreyigit emreyigit Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should verify the loop as well since it was discarding the carry bit before due to unsigned int casting.

// SIZE_MAX
std::vector<int8_t> v = { 0, 0, 0 };
pimpl::twos_complement(v);
ASSERT_EQ((std::vector<int8_t>{ 0, 0, 0 }), v);
}

class AddressHelperTest : public ClientTest
{};

Expand Down
Loading