make count(*) use a QuantifiedObjectValue.of(q) instead of an empty RCV#1
Open
normen662 wants to merge 1 commit intohatyo:refactor_aggregate_match_candidatefrom
Conversation
alecgrieser
approved these changes
Jul 8, 2024
Comment on lines
-246
to
+260
| final var aliasMap = AliasMap.identitiesFor(Sets.union(selectQunValue.getCorrelatedTo(), groupingValues.stream().flatMap(v -> v.getCorrelatedTo().stream()).collect(ImmutableSet.toImmutableSet()))); | ||
| final var pulledUpGroupingValuesMap = selectQunValue.pullUp(groupingValues, aliasMap, ImmutableSet.of(), selectWhereQun.getAlias()); | ||
| final var pulledUpGroupingValues = groupingValues.stream().map(groupingValue -> { | ||
| if (!pulledUpGroupingValuesMap.containsKey(groupingValue)) { | ||
| throw new RecordCoreException("could not pull grouping value " + groupingValue) | ||
| .addLogInfo(LogMessageKeys.VALUE, groupingValue); | ||
| } | ||
| return pulledUpGroupingValuesMap.get(groupingValue); | ||
| }).collect(ImmutableList.toImmutableList()); | ||
| final var aliasMap = AliasMap.identitiesFor( | ||
| Sets.union(selectQunValue.getCorrelatedTo(), | ||
| groupingValues.stream().flatMap(v -> v.getCorrelatedTo().stream()) | ||
| .collect(ImmutableSet.toImmutableSet()))); | ||
| final var pulledUpGroupingValuesMap = | ||
| selectQunValue.pullUp(groupingValues, aliasMap, ImmutableSet.of(), selectWhereQun.getAlias()); | ||
| final var pulledUpGroupingValues = | ||
| groupingValues.stream().map(groupingValue -> { | ||
| if (!pulledUpGroupingValuesMap.containsKey(groupingValue)) { | ||
| throw new RecordCoreException("could not pull grouping value " + groupingValue) | ||
| .addLogInfo(LogMessageKeys.VALUE, groupingValue); | ||
| } | ||
| return pulledUpGroupingValuesMap.get(groupingValue); | ||
| }).collect(ImmutableList.toImmutableList()); |
There was a problem hiding this comment.
These are all white space/line break changes, right? Just making sure I'm not missing anything
hatyo
pushed a commit
that referenced
this pull request
Jan 10, 2025
Update build for relational subprojects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.