Sample implementation of the UI for ETT-1218 (seq) and ETT-745 (full_download) #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: need tests
moseshll
commented
Jan 21, 2026
| "pages" => :pages_eq, | ||
| "full_download" => :full_download_eq | ||
| "full_download" => :full_download_eq, | ||
| "seq" => :seq_eq |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure if ransack needs to even be aware of seq, it won't get used since there's no need to expose it in the UI as a search term.
moseshll
commented
Jan 21, 2026
| class="<%= th_class %>" | ||
| data-filter-control="<%= control %>" | ||
|
|
||
| data-force-export="true" |
Collaborator
Author
There was a problem hiding this comment.
This is the only interesting bit.
moseshll
commented
Jan 21, 2026
| end | ||
| end.sort.uniq | ||
| pages = seq.count | ||
| seq = seq.join(",") |
Collaborator
Author
There was a problem hiding this comment.
I was happy with this little block of code to make a reasonable seq value. You'll never see it except in the exports.
aelkiss
added a commit
that referenced
this pull request
Jan 21, 2026
From #281 TODO: * Incorporate seeds from that PR; test it out * Consider migrating controller test for download export to rspec request spec
aelkiss
added a commit
that referenced
this pull request
Jan 22, 2026
* Add seq in export, but hide from display * Prevent table export from trying to interpret numbers (otherwise it tries to interpret e.g. seq="9,10,11" as if it's a number like 1,000,000) * Incorporates some suggestions from #281 * Request spec for downloads controller json; migrate other downloads controller json tests from minitest
aelkiss
added a commit
that referenced
this pull request
Jan 22, 2026
* Add seq in export, but hide from display * Prevent table export from trying to interpret numbers (otherwise it tries to interpret e.g. seq="9,10,11" as if it's a number like 1,000,000) * Incorporates some suggestions from #281 * Request spec for downloads controller json; migrate other downloads controller json tests from minitest
aelkiss
added a commit
that referenced
this pull request
Jan 22, 2026
* Add seq in export, but hide from display * Prevent table export from trying to interpret numbers (otherwise it tries to interpret e.g. seq="9,10,11" as if it's a number like 1,000,000) * Incorporates some suggestions from #281 * Request spec for downloads controller json; migrate other downloads controller json tests from minitest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is semi-old non-rebased code for edutainment purposes only.
@aelkiss see
app/views/ht_downloads/index.html.erbfor use ofdata-force-exportanddata-visibleto keepseqout of the UI but include it in the export.Do not merge this PR.