ETT-1502: collate uses volume directly to determine repeat

[aelkiss]

Currently in production, we are no longer using LinkedPairtree or LocalPairtree to deposit material. They were responsible for setting is_repeat. Now, collate checks directly.

This points to a sort of mismatch for how for writing to the repository we have abstracted the repository storage, but not for reading what is in the repository. That might be future work to separate out from Volume.

[aelkiss]

This removes the tests and functionality for is_repeat from LinkedPairtree and LocalPairtree. We might want to remove those classes entirely, although LocalPairtree could potentially be a base for future functionality around reading from the repository.

There is a test in Collate for the is_repeat functionality which remains the same and should cover this case:

feed/t/collate.t

Lines 163 to 173 in 795e9f1

	it "logs a repeat when collated twice" => sub {
	my $volume = stage_volume($tmpdirs,'test','test');
	my $stage = HTFeed::Stage::Collate->new(volume => $volume);
	$stage->run;
	# collate same thing again
	$stage = HTFeed::Stage::Collate->new(volume => $volume);
	$stage->run;
	ok($testlog->matches(qw(INFO.*already in repo)));
	};

[aelkiss]

I recommend viewing w/o whitespace changes: https://github.com/hathitrust/feed/pull/182/changes?w=1
since code formatting did a number on it..

[moseshll]

Wow, ignoring whitespace definitely helps. I see no issues here, APPROVE