Add tests for 2up and thumbnail view modes#210
Merged
Conversation
carylwyatt
reviewed
May 20, 2026
Member
carylwyatt
left a comment
carylwyatt
left a comment
There was a problem hiding this comment.
I'm so happy to have additional tests in page turner! Thanks for all your work on this, it's really great! All of my comments have been a little pedantic, and I don't follow best practices all the time, so take it all with a grain of salt. Your tests have done a great job exposing parts of the markup that need improvement, so I'll add these to a list to chat about with Gayathri during UI review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Playwright coverage for 2up and thumbnail views. The existing toolbar spec only checked URL changes when switching views, not that the right content actually rendered. These tests also cover loading views directly via URL param, which was completely untested.