Skip to content

Add Playwright tests for toolbar zoom limits, share panel, and fix silent toBeVisible bug#208

Merged
eumalin merged 2 commits into
mainfrom
firebird/test-coverage-toolbar-share
May 21, 2026
Merged

Add Playwright tests for toolbar zoom limits, share panel, and fix silent toBeVisible bug#208
eumalin merged 2 commits into
mainfrom
firebird/test-coverage-toolbar-share

Conversation

@eumalin
Copy link
Copy Markdown
Contributor

@eumalin eumalin commented May 19, 2026

  • Fix App.spec.js: sidebar test called toBeVisible without (), was always passing
  • ViewerToolbar: add zoom-limits describe block (zoom-in disabled at max, zoom-out
    disabled at min, zoom-out re-enables after zooming back in)
  • sidebar: add share-panel describe block (permanent link, page-scan link, embed modal)

@eumalin eumalin marked this pull request as ready for review May 19, 2026 13:09
@eumalin eumalin requested a review from carylwyatt May 19, 2026 13:09
Comment thread pt/web/firebird/tests/sidebar.spec.js Outdated
Comment thread pt/web/firebird/tests/sidebar.spec.js Outdated
Comment thread pt/web/firebird/tests/sidebar.spec.js Outdated
Comment thread pt/web/firebird/tests/App.spec.js
Comment thread pt/web/firebird/tests/App.spec.js
@eumalin eumalin merged commit 4ae0d8c into main May 21, 2026
2 checks passed
@eumalin eumalin deleted the firebird/test-coverage-toolbar-share branch May 21, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants