ETT-1137, ETT-454: focus indicator changes#207
Merged
Conversation
kron-spar
approved these changes
May 19, 2026
Contributor
kron-spar
left a comment
There was a problem hiding this comment.
Can confirm that the tabbing works as described. I was also able to change the views and use the escape hatch when in the thumbnail view. This looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tickets from the a11y backlog pertaining to keyboard focus issues in page turner are included in this PR.
ETT-1137
The focus indicator around the container for the image/page and its toolbar was not very visible, and the focus indicator around the page itself was completely obscured. I updated the styles for those elements and now the focus indicators are completely visible in most circumstances, and mostly visible if the image is bigger than its container (e.g. if the image is zoomed in or in flip view on a narrow screen).
A side quest during this work was to update the ARIA labels on the image captions so the screen reader announces the OCR text when the screenreader tabs to the scan/image/page.
ETT-454
In thumbnail/grid view, only the first image in the viewport was reachable via the keyboard-- it essentially had a focus trap. You can see this in production currently if you try to move from the first image in the the thumbnail view with your keyboard, you can't do it.
This was a very simple fix once I found how that functionality was being controlled in page turner. I only had to update the
focusedconditional to betruefor thumbnail view. I also tweaked the thumbnail focus indicator styles a bit to match the updates from ETT-1137.To test
This is staged on dev-3. You might...
Let me know if any of these isn't working as expected! Thanks!