TBD Set default value of loading to true#28
Open
ichi404gh wants to merge 1 commit intohasura:masterfrom
Open
Conversation
|
We ran into this issue straight away also, is the repo stale and requiring personal forks? @karthikvt26 are you able to merge and cut a release of the two main feature PRs? |
Collaborator
|
Thanks @ichi404gh for the PR. Have been super busy with some work. Will definitely check it out in some time. @stevokk Will definitely check it out and release them asap. |
|
@karthikvt26 we're starting a new project and pulling the local fix version over, can we get these merged or are you requiring some legwork on our end to help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD
Initial value of
isLoadingisfalseanduserInfoisnull, what is obviously inconsistent. That values are passed to Consumer's children and can lead to wrong behavior, as described in #17, for example.I suggest to set initial
isLoadingvalue totrue, so components can rely on bothisLoadinganduserInfo, especially right after rendering.