Skip to content

Fix typo#11632

Open
zlonast wants to merge 1 commit intohaskell:masterfrom
zlonast:zlonast/remove-cabalism
Open

Fix typo#11632
zlonast wants to merge 1 commit intohaskell:masterfrom
zlonast:zlonast/remove-cabalism

Conversation

@zlonast
Copy link
Collaborator

@zlonast zlonast commented Mar 18, 2026

Fix typo


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@zlonast
Copy link
Collaborator Author

zlonast commented Mar 18, 2026

@philderbeast It seems like these are just typos that needed to be removed, right?

@philderbeast
Copy link
Collaborator

It seems like these are just typos that needed to be removed, right?

For the contributing link, yes, but I don't think that is the case for the test .out files. Those may need to be regenerated or suppressed by the *.test.hs files running the test.

@philderbeast
Copy link
Collaborator

philderbeast commented Mar 18, 2026

I reran the tests and the output uses <ROOT>.

$ cabal run cabal-testsuite:cabal-tests -- --with-cabal=./dist-newstyle/build/x86_64-linux/ghc-9.14.1/cabal-install-3.17.0.0/
x/cabal/build/cabal/cabal cabal-testsuite/PackageTests/SDist/Respect-Project-File/Projects-Default-No/cabal.ignore-project.v2
.test.hs --accept

$ cabal run cabal-testsuite:cabal-tests -- --with-cabal=./dist-newstyle/build/x86_64-linux/ghc-9.14.1/cabal-install-3.17.0.0/
x/cabal/build/cabal/cabal cabal-testsuite/PackageTests/SDist/Respect-Project-File/Projects-Default-No/cabal.no-project.v2.tes
t.hs --accept

Here's the patch for the updated test output:

0001-Rerun-tests-to-get-normalised-output.patch

Copy link
Collaborator

@philderbeast philderbeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a couple of the relative links (not all of them) on your branch and they do indeed work.

@geekosaur
Copy link
Collaborator

The failure's a network error trying to download prerequisites for Rocky Linux; it probably just needs to be retried in an hour or so.

@zlonast zlonast force-pushed the zlonast/remove-cabalism branch 3 times, most recently from 8f626f7 to 348c203 Compare March 18, 2026 18:54
@zlonast
Copy link
Collaborator Author

zlonast commented Mar 18, 2026

Hmmm, maybe this is an internet error? log

    Rerun tests to get normalised output

Co-authored-by: Phil de Joux <philderbeast@gmail.com>
@zlonast zlonast force-pushed the zlonast/remove-cabalism branch from 348c203 to fa9ef1b Compare March 18, 2026 19:17
@geekosaur
Copy link
Collaborator

No, that's Windows locking a file on ghc-pkg.exe, probably due to Windows Defender scanning it. Retrying usually works. Bodigrim's cleaning up various versions of it within cabal, but ghc-pkg.exe is GHC's problem.

@zlonast zlonast added the merge me Tell Mergify Bot to merge label Mar 19, 2026
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants