Include provenance in Backpack unfilled requirements error#11631
Open
jappeace wants to merge 1 commit intohaskell:masterfrom
Open
Include provenance in Backpack unfilled requirements error#11631jappeace wants to merge 1 commit intohaskell:masterfrom
jappeace wants to merge 1 commit intohaskell:masterfrom
Conversation
6645f5d to
5953eb3
Compare
When a non-library component has unfilled Backpack signature requirements, the error message now shows where each requirement came from (e.g. "brought into scope by build-depends: Fail1") using the ModuleSource information already available in the ModuleScope. Updated the Fail3 test golden files and strengthened the test assertion to verify provenance information is present. Addresses haskell#7192 run fourmalou more formatting
5953eb3 to
2eb46b6
Compare
Collaborator
I think it's really too early to talk about significant changes. But once the LLM era arrives, I'd also like to see backpack modules everywhere :) |
Collaborator
|
Also you have only |
Collaborator
Author
|
local fourmolu doesn't change anything, not sure why it's not working on CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a non-library component has unfilled Backpack signature requirements, the error message now shows where each requirement came from (e.g. "brought into scope by build-depends: Fail1") using the ModuleSource information already available in the ModuleScope.
Updated the Fail3 test golden files and strengthened the test assertion to verify provenance information is present.
Addresses #7192
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.