Skip to content

Include provenance in Backpack unfilled requirements error#11631

Open
jappeace wants to merge 1 commit intohaskell:masterfrom
jappeace:backpack-error-provenance
Open

Include provenance in Backpack unfilled requirements error#11631
jappeace wants to merge 1 commit intohaskell:masterfrom
jappeace:backpack-error-provenance

Conversation

@jappeace
Copy link
Collaborator

When a non-library component has unfilled Backpack signature requirements, the error message now shows where each requirement came from (e.g. "brought into scope by build-depends: Fail1") using the ModuleSource information already available in the ModuleScope.

Updated the Fail3 test golden files and strengthened the test assertion to verify provenance information is present.

Addresses #7192

Please read Github PR Conventions and then fill in one of these two templates.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
    • Is the change significant? If so, remember to add significance: significant in the changelog file.
    • I think nobody uses backpack so no not really significant :*(
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

@jappeace jappeace force-pushed the backpack-error-provenance branch from 6645f5d to 5953eb3 Compare March 17, 2026 22:22
When a non-library component has unfilled Backpack signature requirements,
the error message now shows where each requirement came from (e.g.
"brought into scope by build-depends: Fail1") using the ModuleSource
information already available in the ModuleScope.

Updated the Fail3 test golden files and strengthened the test assertion
to verify provenance information is present.

Addresses haskell#7192

run fourmalou

more formatting
@jappeace jappeace force-pushed the backpack-error-provenance branch from 5953eb3 to 2eb46b6 Compare March 17, 2026 22:23
@zlonast
Copy link
Collaborator

zlonast commented Mar 19, 2026

I think nobody uses backpack so no not really significant :*(

I think it's really too early to talk about significant changes. But once the LLM era arrives, I'd also like to see backpack modules everywhere :)

@zlonast
Copy link
Collaborator

zlonast commented Mar 19, 2026

Also you have only fourmolu error and internet error on macos-latest ghc-9.2.8 (we need to restart checks)

@jappeace
Copy link
Collaborator Author

local fourmolu doesn't change anything, not sure why it's not working on CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants