Skip to content

Remove old mkVersion#11630

Open
zlonast wants to merge 5 commits intohaskell:masterfrom
zlonast:zlonast/old-mkVersion
Open

Remove old mkVersion#11630
zlonast wants to merge 5 commits intohaskell:masterfrom
zlonast:zlonast/old-mkVersion

Conversation

@zlonast
Copy link
Collaborator

@zlonast zlonast commented Mar 17, 2026

We don't have any testing for such old versions of ghc. Since this code isn't used, I assume it doesn't work, but it's difficult to confirm otherwise.

We just dropped everything below 8.0.0


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@zlonast
Copy link
Collaborator Author

zlonast commented Mar 17, 2026

Should we drop compilers below 8.6? Or 8.8?

@zlonast zlonast force-pushed the zlonast/old-mkVersion branch 3 times, most recently from 1cd54e4 to 27e6671 Compare March 17, 2026 19:15
@ffaf1
Copy link
Collaborator

ffaf1 commented Mar 17, 2026

This does modify behaviour, does it not?

@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 27e6671 to 9f262e4 Compare March 17, 2026 19:48
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 9f262e4 to 2547133 Compare March 17, 2026 20:17
@zlonast
Copy link
Collaborator Author

zlonast commented Mar 18, 2026

@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior.

@ffaf1
Copy link
Collaborator

ffaf1 commented Mar 18, 2026

@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior.

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants