remove datestamp from bootstrap cache keys#11613
remove datestamp from bootstrap cache keys#11613geekosaur wants to merge 1 commit intohaskell:masterfrom
Conversation
|
EDIT: this comment is now historical; the first version removed the datestamp entirely, because nobody knew why it was there. On second thought, I'm probably closing this in favor of adding a reminder to update the datestamp to things that update the bootstrap JSONs. The problem is that we'll accumulate older versions of source packages. (And probably already have such accumulation, since we haven't been updating the datestamp.) Comments? |
|
Actually, appropriate keys can be computed dynamically by using |
|
Wait, if I save the existing caches we save 4 years of outdated source tarballs. Guess they just have to go. |
faeed08 to
052834d
Compare
4a0b19c to
ddb8407
Compare
|
Uh, anyone know if it's safe to swap the |
ddb8407 to
950755f
Compare
|
Hackage is "down" again, but at least the cache keys now work properly. |
Without some distinct identifier, downloaded sources will accumulate (and have been since the last time the datestamp was updated). The old caches are ignored and will be purged according to GitHub's cache expiration, because otherwise we'd continue to carry 4 years' worth of outdated source tarballs.
950755f to
b570a10
Compare
The intent behind the datestamps was to avoid accumulating out of date source tarballs — which we've been doing since 2022, because nobody's been updating it.
Use a hash computed from the bootstrap JSONs instead, which will be self-updating.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: