Skip to content

BE-644: Run subgraph reads in a single READ ONLY, REPEATABLE READ transaction #8996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claude wants to merge 13 commits into
base: main
Choose a base branch
from
Open

BE-644: Run subgraph reads in a single READ ONLY, REPEATABLE READ transaction #8996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1ee02ab
Redesign migration Context/Transaction traits around an IntoFuture tr…
claude Jul 9, 2026
85a757d
Add a configurable transaction builder to PostgresStore
claude Jul 9, 2026
dd8cc45
Run query_entity_subgraph in a single READ ONLY, REPEATABLE READ tran…
claude Jul 9, 2026
fb5e344
Expect clippy RefCell-across-await lints in adapted benches
claude Jul 9, 2026
ad30f56
Drop IntoFuture imports made redundant by the Rust 2024 prelude
claude Jul 9, 2026
93d4e94
Merge branch 'main' into claude/be-644-snapshot-consistent-subgraph-r…
TimDiekmann Jul 9, 2026
3c09f07
Run query_entities in a single READ ONLY, REPEATABLE READ transaction…
claude Jul 9, 2026
78471f6
Remove inherent duplicates of the Context/Transaction trait methods
claude Jul 10, 2026
498d7d0
Track the transaction state of PostgresStore at the type level
claude Jul 10, 2026
c214a02
Express the read-transaction helpers through the InTransaction typestate
claude Jul 10, 2026
72f6e5a
Gate the InTransaction read-transaction impl behind a test-utils feature
claude Jul 10, 2026
dc931b0
Fix Global lint failures caused by the test-utils self dev-dependency
claude Jul 10, 2026
000a7c8
Rename the inherent entity-store helpers to the _impl convention
claude Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion apps/hash-graph/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions libs/@blockprotocol/type-system/rust/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions libs/@local/codec/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions libs/@local/codegen/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion libs/@local/graph/api/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion libs/@local/graph/api/src/rest/entity/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ where
.await
.map_err(report_to_response)?;

let store = store_pool
let mut store = store_pool
.acquire(temporal_client.0)
.await
.map_err(report_to_response)?;
Expand Down
4 changes: 2 additions & 2 deletions libs/@local/graph/api/src/rest/entity/query/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ where
.attach(hash_status::StatusCode::InvalidArgument)
.map_err(report_to_response)?;

let store = store_pool
let mut store = store_pool
.acquire(temporal_client.0)
.await
.map_err(report_to_response)?;
Expand Down Expand Up @@ -151,7 +151,7 @@ where
.attach(hash_status::StatusCode::InvalidArgument)
.map_err(report_to_response)?;

let store = store_pool
let mut store = store_pool
.acquire(temporal_client.0)
.await
.map_err(report_to_response)?;
Expand Down
1 change: 1 addition & 0 deletions libs/@local/graph/authorization/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions libs/@local/graph/embeddings/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion libs/@local/graph/migrations-macros/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion libs/@local/graph/migrations/docs/dependency-diagram.mmd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v001__extensions/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for Extensions {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for Extensions {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v002__principals/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for Principals {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for Principals {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v003__policies/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for Policies {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for Policies {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v004__webs/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;

pub struct Webs;
Expand All @@ -10,14 +10,14 @@ impl Migration for Webs {

fn up(
self,
_context: &mut <Self::Context as Context>::Transaction<'_>,
_context: &mut ContextTransaction<'_, Self::Context>,
) -> impl Future<Output = Result<(), Report<Self::Error>>> {
core::future::ready(Ok(()))
}

fn down(
self,
_context: &mut <Self::Context as Context>::Transaction<'_>,
_context: &mut ContextTransaction<'_, Self::Context>,
) -> impl Future<Output = Result<(), Report<Self::Error>>> {
core::future::ready(Ok(()))
}
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v005__common_ontology/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for CommonOntology {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for CommonOntology {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v006__data_types/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for DataTypes {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for DataTypes {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v007__property_types/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for PropertyTypes {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for PropertyTypes {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v008__entity_types/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for EntityTypes {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for EntityTypes {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v009__entities/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for Entities {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for Entities {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
6 changes: 3 additions & 3 deletions libs/@local/graph/migrations/graph-migrations/v010__query/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use error_stack::Report;
use hash_graph_migrations::{Context, Migration};
use hash_graph_migrations::{ContextTransaction, Migration};
use tokio_postgres::Client;
use tracing::Instrument as _;

Expand All @@ -11,7 +11,7 @@ impl Migration for Query {

async fn up(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("up.sql"))
Expand All @@ -27,7 +27,7 @@ impl Migration for Query {

async fn down(
self,
context: &mut <Self::Context as Context>::Transaction<'_>,
context: &mut ContextTransaction<'_, Self::Context>,
) -> Result<(), Report<Self::Error>> {
context
.simple_query(include_str!("down.sql"))
Expand Down
Loading
Loading