Skip to content

Conversation

@nevans
Copy link
Contributor

@nevans nevans commented Dec 15, 2025

This will provide early warning for changes, not only to ruby (the language), but also to important default stdlib gems, such as openssl.

For example, this will not pass until the following other PRs are merged:

It passes for me (locally) with those both merged.

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.1...8e8c483)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@nevans nevans requested a review from a team as a code owner December 15, 2025 23:10
@nevans
Copy link
Contributor Author

nevans commented Dec 23, 2025

@chrisarcand Any thoughts on this #361 and #362 (which are needed for ruby 4.0 compatibility) or this PR (which will help detect future compatibility issues a little bit sooner)?

If you don't have time before then, that's fine (and very relatable!). I'll update this PR after the 4.0 release to add 4.0 to the matrix, too.

Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.221.0 to 1.280.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb)
- [Commits](ruby/setup-ruby@32110d4...d5f787c)

---
updated-dependencies:
- dependency-name: ruby/setup-ruby
  dependency-version: 1.280.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
chrisarcand
chrisarcand previously approved these changes Jan 12, 2026
@chrisarcand
Copy link
Member

Sweet! Other PRs merged. Go ahead and add 4.0 and let's watch it pass :)

This will provide early warning for changes, not only to ruby (the
language), but also to important default stdlib gems, such as `openssl`.

For example, CI will break with the `openssl` 4.0 gem, because it
modifies `OpenSSL::SSL::SSLContext::DEFAULT_PARAMS`.
@nevans nevans force-pushed the add-ruby-HEAD-to-CI branch from 105ff78 to ba31c0f Compare January 12, 2026 15:38
@nevans
Copy link
Contributor Author

nevans commented Jan 12, 2026

@chrisarcand Thanks! I had to update the GitHub Action for ruby/setup-ruby, but it's all passing now.

@nevans nevans changed the title Add ruby HEAD to CI Add ruby 4.0 and HEAD to CI Jan 12, 2026
@nevans
Copy link
Contributor Author

nevans commented Jan 12, 2026

Actually, I'm going to rewind that last commit and just merge #355 and #372 into this PR. That'll automatically close all three PRs when this one is merged (and add all three to the release notes, if you use that).

@nevans nevans force-pushed the add-ruby-HEAD-to-CI branch from 06e44e8 to edf049c Compare January 12, 2026 15:54
@chrisarcand
Copy link
Member

chrisarcand commented Jan 12, 2026

Looks like there's some conflicts to settle

@nevans
Copy link
Contributor Author

nevans commented Jan 12, 2026

@chrisarcand I'm not seeing any conflicts on GitHub... but I did rebase, force push, then rewind a commit, and force push that. Are you seeing local conflicts? Maybe try git remote update && git reset --hard @{upstream}?

@chrisarcand
Copy link
Member

Weird! I'm seeing this:

CleanShot 2026-01-12 at 10 06 47

I'll toy with it a bit.

@chrisarcand
Copy link
Member

Yeah, needs some help:

CleanShot 2026-01-12 at 10 08 40 CleanShot 2026-01-12 at 10 08 53

@chrisarcand
Copy link
Member

I can squash merge instead, that's fine.

@chrisarcand chrisarcand merged commit 4f5e5e6 into hashicorp:master Jan 12, 2026
26 checks passed
@nevans
Copy link
Contributor Author

nevans commented Jan 12, 2026

Ah, that explains it. You were using rebase (for flat history, I presume). Because I did use a couple of merge commits for #355 and #372, and git's flat rebase throws away any information from the merge commits (which was needed to resolve the conflict).

@nevans
Copy link
Contributor Author

nevans commented Jan 12, 2026

I personally use a (slightly idiosyncratic) workflow (which I forget is idiosyncratic): I only "rebase merge" single commit PRs, I use "regular" merge commits for multi-commit PRs, and I usually only use "squash merge" on dependabot PRs (because of dependabot/dependabot-core/issues/4565 😉). So I usually forget that the rebase PR merge will be confused by merge commits. But squash should pretty much always get the job done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants