-
Notifications
You must be signed in to change notification settings - Fork 138
Add ruby 4.0 and HEAD to CI #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.1...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
@chrisarcand Any thoughts on this #361 and #362 (which are needed for ruby 4.0 compatibility) or this PR (which will help detect future compatibility issues a little bit sooner)? If you don't have time before then, that's fine (and very relatable!). I'll update this PR after the 4.0 release to add 4.0 to the matrix, too. |
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.221.0 to 1.280.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@32110d4...d5f787c) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.280.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Sweet! Other PRs merged. Go ahead and add 4.0 and let's watch it pass :) |
This will provide early warning for changes, not only to ruby (the language), but also to important default stdlib gems, such as `openssl`. For example, CI will break with the `openssl` 4.0 gem, because it modifies `OpenSSL::SSL::SSLContext::DEFAULT_PARAMS`.
105ff78 to
ba31c0f
Compare
|
@chrisarcand Thanks! I had to update the GitHub Action for |
…etup-ruby-1.280.0' into add-ruby-HEAD-to-CI
…s/checkout-6.0.1' into add-ruby-HEAD-to-CI
06e44e8 to
edf049c
Compare
|
Looks like there's some conflicts to settle |
|
@chrisarcand I'm not seeing any conflicts on GitHub... but I did rebase, force push, then rewind a commit, and force push that. Are you seeing local conflicts? Maybe try |
|
I can squash merge instead, that's fine. |
|
I personally use a (slightly idiosyncratic) workflow (which I forget is idiosyncratic): I only "rebase merge" single commit PRs, I use "regular" merge commits for multi-commit PRs, and I usually only use "squash merge" on dependabot PRs (because of dependabot/dependabot-core/issues/4565 😉). So I usually forget that the rebase PR merge will be confused by merge commits. But squash should pretty much always get the job done. |



This will provide early warning for changes, not only to ruby (the language), but also to important default stdlib gems, such as
openssl.For example, this will not pass until the following other PRs are merged:
It passes for me (locally) with those both merged.