[deps] Update go-winio fork and rebase on current upstream#22399
Draft
[deps] Update go-winio fork and rebase on current upstream#22399
Conversation
This replaces the forked go-winio from github.com/endocrimes/go-winio to my github.com/angrycub/go-winio instead. This goal being to eventually move the fork to a HashiCorp owned repo. My fork brings the library up to current main plus Dani's (@endocrimes) patches for ListenOnlyPipe
angrycub
added
stage/needs-discussion
theme/dependencies
tgross
approved these changes
May 29, 2024
Member
tgross
left a comment
tgross
left a comment
There was a problem hiding this comment.
LGTM as far as Nomad goes.
For the forked repo, I'd suggest we might want to have the "forked from" point to the original upstream and then apply Dani's patch on top of that (preserving authorship, obviously!), so that someone can see at a glance what patch we're carrying and pull in changes cleanly. Alternately, could we get the patch upstreamed? It'd be nice to let upstream take care of it going forward.
Contributor
|
@tgross me and @notnoop have tried to little avail (microsoft/go-winio#170) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the forked
go-winiofrom endocrimes/go-winio to angrycub/go-winio. This goal being to eventually move the fork to a HashiCorp owned repo. My fork brings the library up to current main plus @endocrimes 's patches forListenOnlyPipe