This repository was archived by the owner on Jun 27, 2025. It is now read-only.
Implement deep merge functionality for multiple variable files #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when multiple variable files were provided, nested objects would be completely overwritten by subsequent files instead of being merged. This change implements proper deep merging of nested structures. Changes: - Add deepMerge() function for recursive map merging - Add convertYAMLMap() functions to handle YAML parsing edge cases - Replace simple key assignment with deep merge in variable processing - Add comprehensive tests for YAML, JSON, and Terraform variable files - Test cases verify proper merging of nested database, cache, and logging configs Fixes variable file overwriting bug where providing two variable files resulted in loss of nested configuration from the first file. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when multiple variable files were provided, nested objects would be completely overwritten by subsequent files instead of being merged. This change implements proper deep merging of nested structures.
Changes:
Fixes variable file overwriting bug where providing two variable files resulted in loss of nested configuration from the first file.
🤖 Generated with Claude Code