-
Notifications
You must be signed in to change notification settings - Fork 164
feat: 2232 Improve schema version handling #5635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
* Replace `p-table` with `p-treeTable` and implement hierarchical view for schemas. * Add grouping logic to associate schemas by topic and type. * Update styles to support the new tree table layout. * Integrate `TreeTableModule` and `TreeNode` from PrimeNG. Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
* Add `ModelHelper.versionCompare` to validate version increments in set-version-dialog. * Pass schema data to set-version-dialog for version validation. * Display previous version in set-version-dialog UI. * Update `setVersion` logic in schema-helper to handle existing versions. Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
Test Results 32 files ±0 64 suites ±0 5m 31s ⏱️ - 2m 15s For more details on these failures, see this check. Results for commit adcfd6e. ± Comparison against base commit a2193cc. ♻️ This comment has been updated with latest results. |
Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
- Introduce `topicCount` property in schema data model and DTOs. - Calculate and display total and visible schema counts per topic in the UI. - Enhance schemas component with filtering, count display, and tree table improvements. Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
- Add `incrementHighestSchemaVersion` helper to calculate schema version based on the highest existing version in the topic. - Enhance dropdown UI in the schemas component with custom templates for better user experience. Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
…ements - Add default "All Tools" option to the tools dropdown. Signed-off-by: Daniel Angelovski <daniel.angelovski@envisionblockchain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improve schema version handling, visually grouping by policy, and also improve schema versioning by enforcing correct format of versioning.
Related issue(s):
Fixes #2232
Notes for reviewer:
Checklist