Skip to content

Add Agentgram plugin#163

Open
jerryfane wants to merge 2 commits into
hashgraph-online:mainfrom
jerryfane:add-agentgram-plugin
Open

Add Agentgram plugin#163
jerryfane wants to merge 2 commits into
hashgraph-online:mainfrom
jerryfane:add-agentgram-plugin

Conversation

@jerryfane
Copy link
Copy Markdown

Summary

  • add Agentgram under Tools & Integrations
  • mirror the installable Agentgram plugin bundle from jerryfane/agentgram
  • update plugins.json and the Codex marketplace metadata

Validation

  • python3 scripts/check-alphabetical.py README.md
  • python3 scripts/validate-plugin-pr.py --base-ref origin/main
  • python3 /root/.codex/skills/.system/plugin-creator/scripts/validate_plugin.py /tmp/awesome-codex-plugins-agentgram/plugins/jerryfane/agentgram
  • git diff --check

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request registers and integrates "Agentgram", a local-first Telegram messaging plugin and CLI for AI agents, into the marketplace, README, and plugins metadata. The review feedback highlights two issues: an incorrect local path configuration in the plugin's marketplace manifest that will cause installation failures, and a reference in the skill instructions to a fallback bin/ directory that is missing from the mirrored files.

"name": "agentgram",
"source": {
"source": "local",
"path": "./plugins/agentgram"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The path "./plugins/agentgram" is incorrect because the plugin files are located at the root of this mirrored directory (i.e., plugins/jerryfane/agentgram/). When installed via this local marketplace file, it will fail to resolve the plugin. It should be updated to . to correctly point to the root of the plugin bundle.

Suggested change
"path": "./plugins/agentgram"
"path": "."

Before sending messages, prefer the installed `agentgram` command. If it is not
on `PATH` and Agentgram is installed as a Codex plugin, resolve the plugin root
from this skill file at `<plugin-root>/skills/agentgram/SKILL.md` and use
`<plugin-root>/bin/agentgram` (`../../bin/agentgram` relative to this file). Use
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The skill instructions reference <plugin-root>/bin/agentgram as a fallback execution path. However, the bin/agentgram executable (and the bin/ directory) is not included in the mirrored files in this repository. If the agentgram command is not available on the user's PATH, this fallback path will fail. Please ensure that the necessary executable files are mirrored or update the instructions accordingly.

@jerryfane
Copy link
Copy Markdown
Author

Addressed the review feedback in 46de383:

  • plugins/jerryfane/agentgram/.agents/plugins/marketplace.json now points at dot/current directory, so the nested local marketplace resolves to the mirrored bundle root.
  • The mirrored Agentgram bundle now includes bin/agentgram and src/agentgram_tg, so the skill fallback path works.

Validation rerun:

  • python3 scripts/check-alphabetical.py README.md
  • python3 scripts/validate-plugin-pr.py --base-ref origin/main
  • python3 /root/.codex/skills/.system/plugin-creator/scripts/validate_plugin.py /tmp/awesome-codex-plugins-agentgram/plugins/jerryfane/agentgram
  • git diff --check
  • smoke-installed agentgram@awesome-codex-plugins from the local marketplace and ran bin/agentgram --version, which returned agentgram 0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant