Match MY_Form_validation constructor call signature with parent class#35
Open
jeteon wants to merge 3 commits intohaseydesign:masterfrom
Open
Match MY_Form_validation constructor call signature with parent class#35jeteon wants to merge 3 commits intohaseydesign:masterfrom
MY_Form_validation constructor call signature with parent class#35jeteon wants to merge 3 commits intohaseydesign:masterfrom
Conversation
Fix constructor arguments to be compatible with the original `CI_Form_validation` constructor and pass on any arguments given. I won't pretend to the know the reason now, but if you don't do this, then the validation rules you set in a global config file as described in https://ellislab.com/codeIgniter/user-guide/libraries/form_validation.html aren't used.
Match `MY_Form_validation` constructor signature with parent class
The forum thread on the Ellis Lab website is no longer there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this change allowed me to use validation rules that are defined in a global configuration file as described in https://ellislab.com/codeIgniter/user-guide/libraries/form_validation.html. I'm not sure if the absence of the argument is intentional, but I feel matching the call signature of a class that is inherited from is a good thing overall.