Open
Conversation
lbjay
reviewed
Apr 15, 2025
| */ | ||
| const cfnStackExists = async ( | ||
| stackName: string, | ||
| profile = 'default', |
Member
There was a problem hiding this comment.
Could this look for an $AWS_PROFILE env var before defaulting to 'default'? My default profile is called 'test'.
lbjay
reviewed
Apr 15, 2025
|
|
||
| // disable cdk prompting if user included `--yes` flag | ||
| if (yes && (cdkArgs.includes('deploy') || cdkArgs.includes('changeset'))) { | ||
| cdkArgs.push('--require-approval-never'); |
Member
There was a problem hiding this comment.
Does this work? The form I have always used is --require-approval=never
This reverts commit 4ea25d0.
Benni-Math
force-pushed
the
refactor/oclif
branch
from
d809d31 to
ebaf4d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.