feat: return signed log download URLs from harness_diagnose when return_download_url is set#358
Merged
thisrohangupta merged 1 commit intoJun 18, 2026
Conversation
…rn_download_url is set Add resolveDiagnoseLog helper so pipeline diagnostics can return signed logs.zip URLs instead of buffering inline log text, matching harness_get execution_log behavior. Enables agents to fetch and paginate logs locally without OOM risk. Adapted from Saranya-jena#1 Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports the remaining changes from Saranya-jena/mcp-server#1 onto
main.harness_getforexecution_logalready supportedreturn_download_url=trueon main (viaresolveLogDownloadUrl). This PR completes the feature by wiring the same opt-in throughharness_diagnosepipeline diagnostics:options.return_download_url=true, failed step logs andrequested_step_logreturn{ download_url: "<signed logs.zip URL>" }instead of inline/truncated log text.Changes
src/tools/diagnose/pipeline.ts: AddresolveDiagnoseLoghelper; honorreturn_download_urlfor failed steps, explicit step requests, and auto-fetched success logs.src/tools/harness-diagnose.ts: Documentreturn_download_urlin pipeline diagnostic options.harness_getexecution_log URL mode, andresolveLogDownloadUrl.Type of Change
Checklist
pnpm test— 1994 tests)Credit
Based on work by @Saranya-jena in Saranya-jena#1