Skip to content

Fix log download URL option schema#356

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/critical-bug-investigation-81bc
Draft

Fix log download URL option schema#356
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/critical-bug-investigation-81bc

Conversation

@cursor

@cursor cursor Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

Expose return_download_url on the public harness_get input schema so schema-driven MCP clients preserve the URL-only log retrieval option. Without this, callers asking for a signed execution-log URL could have the option stripped and fall back to resolveLogContent(), which downloads and buffers log content instead of returning the link.

Added regression coverage that simulates schema filtering and asserts the handler uses resolveLogDownloadUrl() rather than resolveLogContent().

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other

Checklist

  • Tests pass
  • Typecheck passes

Validation performed:

  • pnpm exec vitest run tests/tools/tool-handlers.test.ts -t "execution_log" failed before the fix, then passed after it
  • pnpm build
  • pnpm docs:generate
  • pnpm typecheck
  • pnpm docs:check
  • git diff --check
  • pnpm test
Open in Web View Automation 

cursoragent and others added 2 commits June 17, 2026 11:10
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants