Fix log download URL option schema#356
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose
return_download_urlon the publicharness_getinput schema so schema-driven MCP clients preserve the URL-only log retrieval option. Without this, callers asking for a signed execution-log URL could have the option stripped and fall back toresolveLogContent(), which downloads and buffers log content instead of returning the link.Added regression coverage that simulates schema filtering and asserts the handler uses
resolveLogDownloadUrl()rather thanresolveLogContent().Type of Change
Checklist
Validation performed:
pnpm exec vitest run tests/tools/tool-handlers.test.ts -t "execution_log"failed before the fix, then passed after itpnpm buildpnpm docs:generatepnpm typecheckpnpm docs:checkgit diff --checkpnpm test