Fix execution log download URL handling#339
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a critical breakage in the
execution_logURL-only path:return_download_urlin the publicharness_getinput schema so schema-driven MCP clients can use the opt-in instead of falling back to buffered log retrieval.resolveLogDownloadUrl()fail fast for Harness log-service blob links that require MCP server auth/proxying, rather than returning a URL that callers cannot fetch directly.Type of Change
Checklist
Validation:
pnpm buildpnpm docs:generatepnpm docs:checkpnpm typecheckpnpm exec vitest run tests/utils/log-resolver.test.ts tests/tools/tool-handlers.test.ts -t 'resolveLogDownloadUrl|return_download_url'pnpm test