Fix Knowledge Graph query-service response unwrapping#321
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a Knowledge Graph response-shape regression where query-service endpoints that return
{ data: ... }or{ result: ... }envelopes were only unwrapped for HQLrun. The same wrapped shape caused queryable type discovery to return an empty list, grammar fetches to leak the envelope instead of returning text, and HQL validation to dropis_valid.Root cause:
hqlRunExtracthandled query-service envelopes, butkg_queryable_type_summary,kg_grammar, and HQLvalidateread only top-level fields.Fix: add a shared query-service envelope unwrap helper and use it across all Knowledge Graph query-service extractors. Added registry-level regression tests for wrapped discovery, grammar, and validation responses.
Type of Change
Checklist
Verification:
pnpm buildpnpm docs:generatepnpm typecheckpnpm test