Fix JSON-string File Store body preview redaction#306
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a File Store confirmation-preview data exposure bug where
harness_create/harness_updateredacted upload fields for object bodies but leakedcontentorcontent_base64when the same body was supplied as a supported JSON string.formatBodyPreviewnow parses JSON-string bodies and applies the same redaction/truncation replacer before elicitation.Bug and impact: File Store upload payloads could appear in confirmation prompts, exposing plaintext file content or encoded payloads to MCP client UI/log surfaces before multipart validation ran.
Root cause: JSON-string
bodyinputs were coerced for dispatch, but confirmation preview used the original string and skipped key-based redaction.Fix and validation: Added handler-level regressions for JSON-string File Store create/update payloads and updated preview formatting centrally.
Type of Change
Checklist
Validation performed:
pnpm exec vitest run tests/tools/tool-handlers.test.ts -t "JSON-string .*confirmation prompts"(red before fix, green after)pnpm exec vitest run tests/tools/tool-handlers.test.ts tests/registry/file-store-multipart.test.tspnpm typecheckpnpm buildgit diff --check origin/main...HEADpnpm test