fix: warn on invalid auto-approve-risk header; make config required in write tools#207
Open
sunilgattupalle wants to merge 1 commit into
Open
fix: warn on invalid auto-approve-risk header; make config required in write tools#207sunilgattupalle wants to merge 1 commit into
sunilgattupalle wants to merge 1 commit into
Conversation
…d in write tool registrars Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> AI-Session-Id: e99a0003-1e04-4235-896a-f22400d45734 AI-Tool: claude-code AI-Model: unknown
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #204 — two review nits that were in a commit on the PR branch but didn't make it into the merge.
session-headers.ts: log awarnwhenX-Harness-Auto-Approve-Riskcontains an unrecognized value (e.g."read", typos) instead of silently falling back to the deployment default. Prevents confusing silent behavior where a misconfigured client gets a different security posture than intended.harness_create,harness_update,harness_delete,harness_execute): changeconfig?: Config→config: Config. The parameter is always passed byregisterAllTools— making it optional was a type lie that would let future callers omit it and silently use the process-global auto-approve default instead of the session value.Test plan
pnpm typecheckpassespnpm testpassesX-Harness-Auto-Approve-Risk: readheader in an HTTP session logs a warning and uses the deployment default🤖 Generated with Claude Code